This is an automated email from the ASF dual-hosted git repository.

leerho pushed a change to branch comment_changes
in repository 
https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git.


    from 00a299c  Minor changes in code comment for clarity.
     add d72cc02  [WIP] add catch, move sampling and frequent items tests to 
catch
     add 1ab1b92  convert kll and cpc to catch2 tests
     add 2581b1c  migrate hll, theta to catch2 for testing
     add e82dfd7  [still WIP] comment out unsued test function, but keep for 
possible future debugging
     add 7574e7a  attempt at a CI build
     add 12d829b  remove dependence on cppunit
     add c8e5ff4  remove cppunit from CI workflow, fix missing include and 
warnings from signed/unsigned comparisons
     add 4838cbf  cleanup cmake interface definitions, fix more comparison 
warnings, fix isnan issue in sampling
     add f84f41c  try adding windows to CI matrix, enable python tests, and 
loosen one python kll bound a bit to reduce occasional test failures
     add 3bf37df  syntax fix in workflow file
     add e37e8ff  specify python3 in workflow
     add 6d8087a  workflow: disable windows builds, install python dependencies
     add d679b35  workflow: typo fix
     add c3314bb  fix ubuntu compiler warnings in python wrapper
     add f71b87f  Merge branch 'master' of 
github.com:apache/incubator-datasketches-cpp into catch2_tests
     add eb3f0a5  use tox for python tests and merge new kll changes from master
     add 188d1cc  define single DEFAULT_SEED and zero-counting class, clean up 
python manifest
     add 2943b6d  fix a signed/unsigned comparison warning
     add b09ad46  replace and/or with &&/||, respectively, in a few spots
     add 585d14c  one more or to ||, cmake changes to help with windows paths
     add 47050fc  two more and to && changes
     add 7da5dd2  fix throw-after-allocation leak where memory wasn't freed if 
exception in constructor
     add 1ad6f36  Enable MinGW in CI
     add aa89af7  revert mingw change
     add 933a9c3  another test of windows CI
     add 57a401e  specify release config for windows
     add ddc6b52  Merge branch 'windows_fixes' of 
github.com:apache/incubator-datasketches-cpp into windows_fixes
     add 33353b1  fix var_opt reset() memory leak
     add 9f2d398  set flag to free gap once reservoir fills
     add 0f3612f  no need to expose these methods
     add 2469613  destructor must be public
     add 13664ca  better summary
     add a7f9069  Merge branch 'master' into api_and_docs
     add 9d9e521  docs
     add dcc45f2  docs
     add 50d7356  doc
     add 8668df4  doc
     add 1cb225c  doc
     add 4b6ec7c  removed unnecessary constructor
     add 88e6cd6  added check
     add d5479d0  doc
     add 8337973  doc
     add c8d2830  doc
     add 87878a1  doc
     add f7b9f44  doc
     add 91dcc88  indentation fix
     add 8f37f64  Merge pull request #107 from apache/catch2_tests
     add faf150e  Merge pull request #108 from apache/common_cleanup
     add 46b2945  Merge branch 'master' into api_and_docs
     add c711b0a  Merge pull request #109 from apache/api_and_docs
     add c65bdbe  fix memory leak in theta_union::get_result()
     add 7c0c7ee  Merge pull request #111 from apache/theta_memory_fix
     add 601f2b9  Merge branch 'master' of 
github.com:apache/incubator-datasketches-cpp into windows_fixes
     add b9ef419  avoid deallocate() call on nullptr in theta sketch dtors
     add 86e7eee  Merge pull request #112 from apache/windows_fixes
     add 7bdb207  fix memory leak in test code for hll and cpc, fix 
throw-after-allocate in cpc constructor
     add b4c0b0a  FI: test to check k limit, fix hash map dtor to remove leak
     add 5a07fed  Merge pull request #113 from apache/memory_fixes
     add 92c3d30  remove hll union serialization, fix a few unused variable 
warnings
     add 80e80a9  missed one file in previous commit
     add ce6f5df  add new memory_operations.hpp for bounds checks, modify theta 
and add checks to cpc
     add 3704dcf  use new memory methods in varopt, fix a bunch of compiler 
warnings
     add c0ba29a  compatibility with Java
     add aeaea9e  hip=0 if ooo
     add f342a3f  Merge pull request #114 from apache/cross_lang_compat
     add 9972cc2  mix the result of given hash function in case it is not very 
good
     add c65862a  fixed the order of arguments that has changed recently, but 
not reflected here
     add 374531d  off-by-one mistake
     add ff788fd  Merge pull request #115 from apache/fi_use_fmix64
     add 716ccec  Merge branch 'master' of 
github.com:apache/incubator-datasketches-cpp into check_buffer_bounds
     add f67102e  add bounds checks to frequent items
     add c686e99  revert sampling changes unrelated to memory limits, add check 
sin kll, remove union serialization from python hll
     add 5e741ed  Merge pull request #116 from apache/check_buffer_bounds
     add 7e7f598  use std::out_of_range exceptions when checking memory capacity
     add 115e921  update unit tests to catch out_of_range
     add 23c3cc8  Merge pull request #117 from apache/hll_exceptions
     add 099a433  add vector_bytes to sampling, remove useless const
     add d811d06  Merge pull request #118 from apache/sampling_vector_bytes
     add b5c0174  remove signed/unsigned comparison warnings from varopt, 
enable more compiler warnings
     add 3c91706  varopt fix in dtor when k < curr_items_alloc
     add 77f7433  don't copy possibly invalid gap item from varopt sketches
     add 4913489  Merge pull request #119 from apache/sampling_cleanup
     add c402f4f  update instructions, license file, notice, and add 
documentation to varopt
     add c7bc7aa  Merge pull request #120 from apache/documentation
     add 86dee95  deserialize overrun tests
     add 0900ed4  deserialize overrun tests
     add c5ce967  deserialize overrun tests
     add 2398c0a  serialization-deserialization tests including buffer overrun
     add 9a4a090  fix incorrect memory size calculations causing test failures
     add f99047d  more tests
     add c3f0278  Merge pull request #121 from apache/overrun_tests
     add e8527eb  exception-handling serde attemption. i think there's still an 
edge case
     add fe6a8cd  avoid edge case in exception-ready std::string serde rewrite
     add d48e73d  Merge pull request #123 from apache/serde_exception
     add 511a5f7  moved all deserialization into corresponding static methods
     add 89765b8  use vector for levels
     add 87b6720  fixed debug print
     add aaa69fc  exception safety
     add 3f9b12e  Merge pull request #122 from apache/kll_exception_safety
     add b77fcdd  exception-safe deserialize
     add 10edcd7  Merge pull request #124 from apache/fi_exception_safety
     new ee71ef4  Merge branch 'master' into comment_changes

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .github/workflows/build_cmake.yml                  |    60 +
 CMakeLists.txt                                     |     5 +-
 MANIFEST.in                                        |    21 +-
 NOTICE                                             |    21 +-
 README.md                                          |    29 +-
 cmake/FindCppUnit.cmake                            |    42 -
 common/CMakeLists.txt                              |     9 +-
 common/include/CommonUtil.hpp                      |    71 -
 .../test_allocator.cpp => include/common_defs.hpp} |    12 +-
 .../include/count_zeros.hpp                        |    15 +-
 common/include/memory_operations.hpp               |    57 +
 common/include/serde.hpp                           |   132 +-
 common/test/CMakeLists.txt                         |    17 +-
 common/test/catch.hpp                              | 17618 +++++++++++++++++++
 common/test/catch_runner.cpp                       |     7 +
 common/test/test_type.hpp                          |     2 +-
 cpc/CMakeLists.txt                                 |     4 -
 cpc/include/cpc_common.hpp                         |     1 -
 cpc/include/cpc_compressor_impl.hpp                |     3 +-
 cpc/include/cpc_sketch.hpp                         |   355 +-
 cpc/include/cpc_sketch_impl.hpp                    |    12 +
 cpc/include/cpc_union.hpp                          |    90 +-
 cpc/include/cpc_union_impl.hpp                     |     9 +-
 cpc/test/CMakeLists.txt                            |    11 +-
 cpc/test/compression_test.cpp                      |    77 +-
 cpc/test/cpc_sketch_test.cpp                       |   729 +-
 cpc/test/cpc_union_test.cpp                        |   251 +-
 fi/CMakeLists.txt                                  |     2 -
 fi/include/frequent_items_sketch.hpp               |   202 +-
 fi/include/frequent_items_sketch_impl.hpp          |    77 +-
 fi/include/reverse_purge_hash_map_impl.hpp         |    23 +-
 fi/test/CMakeLists.txt                             |     8 +-
 fi/test/frequent_items_sketch_custom_type_test.cpp |   122 +-
 fi/test/frequent_items_sketch_test.cpp             |   663 +-
 fi/test/reverse_purge_hash_map_test.cpp            |    55 +-
 hll/CMakeLists.txt                                 |     2 -
 hll/include/AuxHashMap-internal.hpp                |     4 +-
 .../CompositeInterpolationXTable-internal.hpp      |     6 +-
 hll/include/CompositeInterpolationXTable.hpp       |     6 +-
 hll/include/CouponHashSet-internal.hpp             |     6 +-
 hll/include/CouponList-internal.hpp                |    11 +-
 hll/include/HllArray-internal.hpp                  |    12 +-
 hll/include/HllSketch-internal.hpp                 |    19 +-
 hll/include/HllSketchImplFactory.hpp               |     1 -
 hll/include/HllUnion-internal.hpp                  |    21 +-
 hll/include/HllUtil.hpp                            |    54 +-
 hll/include/hll.hpp                                |    31 +-
 hll/test/AuxHashMapTest.cpp                        |   124 +-
 hll/test/CMakeLists.txt                            |     3 +-
 hll/test/CouponHashSetTest.cpp                     |   226 +-
 hll/test/CouponListTest.cpp                        |   334 +-
 hll/test/CrossCountingTest.cpp                     |   141 +-
 hll/test/HllArrayTest.cpp                          |   357 +-
 hll/test/HllSketchTest.cpp                         |   511 +-
 hll/test/HllUnionTest.cpp                          |   641 +-
 hll/test/IsomorphicTest.cpp                        |   198 +-
 hll/test/TablesTest.cpp                            |    51 +-
 hll/test/ToFromByteArrayTest.cpp                   |   271 +-
 kll/CMakeLists.txt                                 |     2 -
 kll/include/kll_helper.hpp                         |     4 +-
 kll/include/kll_sketch.hpp                         |   228 +-
 kll/include/kll_sketch_impl.hpp                    |   321 +-
 kll/test/CMakeLists.txt                            |     8 +-
 kll/test/kll_sketch_custom_type_test.cpp           |   113 +-
 kll/test/kll_sketch_test.cpp                       |   619 +-
 kll/test/kll_sketch_validation.cpp                 |   147 +-
 pyproject.toml                                     |    12 +
 python/README.md                                   |     2 +
 python/src/cpc_wrapper.cpp                         |     6 +-
 python/src/hll_wrapper.cpp                         |    18 -
 python/src/kll_wrapper.cpp                         |     6 +-
 python/src/theta_wrapper.cpp                       |    37 +-
 python/tests/hll_test.py                           |     9 -
 python/tests/kll_test.py                           |     4 +-
 sampling/CMakeLists.txt                            |     2 -
 sampling/include/var_opt_sketch.hpp                |   170 +-
 sampling/include/var_opt_sketch_impl.hpp           |   211 +-
 sampling/include/var_opt_union.hpp                 |    89 +-
 sampling/include/var_opt_union_impl.hpp            |     2 +-
 sampling/test/CMakeLists.txt                       |     8 +-
 sampling/test/var_opt_sketch_test.cpp              |   910 +-
 sampling/test/var_opt_union_test.cpp               |   609 +-
 setup.py                                           |     3 +-
 theta/CMakeLists.txt                               |     2 -
 theta/include/theta_a_not_b.hpp                    |    13 +-
 theta/include/theta_a_not_b_impl.hpp               |     6 +-
 theta/include/theta_intersection.hpp               |    29 +-
 theta/include/theta_sketch.hpp                     |   288 +-
 theta/include/theta_sketch_impl.hpp                |    35 +-
 theta/include/theta_union.hpp                      |    47 +
 theta/include/theta_union_impl.hpp                 |     5 +-
 theta/test/CMakeLists.txt                          |     3 +-
 theta/test/theta_a_not_b_test.cpp                  |   403 +-
 theta/test/theta_intersection_test.cpp             |   406 +-
 theta/test/theta_sketch_test.cpp                   |   767 +-
 theta/test/theta_union_test.cpp                    |   157 +-
 96 files changed, 23799 insertions(+), 5744 deletions(-)
 create mode 100644 .github/workflows/build_cmake.yml
 delete mode 100644 cmake/FindCppUnit.cmake
 delete mode 100644 common/include/CommonUtil.hpp
 copy common/{test/test_allocator.cpp => include/common_defs.hpp} (84%)
 rename cpc/include/counter_of_zeros.hpp => common/include/count_zeros.hpp (92%)
 create mode 100644 common/include/memory_operations.hpp
 create mode 100644 common/test/catch.hpp
 create mode 100644 common/test/catch_runner.cpp


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to