leerho commented on pull request #151: URL: https://github.com/apache/incubator-datasketches-cpp/pull/151#issuecomment-635675129
The way we do this check in Java is more comprehensive in that an empty Theta sketch has a distinctive signature that allows us to accommodate older data that had bugs, for example the Empty or ordered flags were not set when they should have been. Yet we had a lot of historical sketches stored this way. Whether we need/want to burden C++ with these historical binary compatibility issues is an open question. You can see this code with comments [here](https://github.com/apache/incubator-datasketches-java/blob/master/src/main/java/org/apache/datasketches/theta/EmptyCompactSketch.java) Lines 32-61. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
