This is an automated email from the ASF dual-hosted git repository. jmalkin pushed a commit to branch patch_for_rc4 in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git
commit 9b1b34b7ba7f833d6e2278321535ea860383586e Author: AlexanderSaydakov <[email protected]> AuthorDate: Fri May 29 16:59:36 2020 -0700 reference member is problematic --- theta/include/conditional_back_inserter.hpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/theta/include/conditional_back_inserter.hpp b/theta/include/conditional_back_inserter.hpp index f128a3b..2e40e9f 100644 --- a/theta/include/conditional_back_inserter.hpp +++ b/theta/include/conditional_back_inserter.hpp @@ -28,7 +28,7 @@ namespace datasketches { template <class Container, class Predicate> class conditional_back_insert_iterator: public std::back_insert_iterator<Container> { public: - conditional_back_insert_iterator(Container& c, Predicate& p): std::back_insert_iterator<Container>(c), p(p) {} + conditional_back_insert_iterator(Container& c, Predicate&& p): std::back_insert_iterator<Container>(c), p(std::forward<Predicate>(p)) {} conditional_back_insert_iterator& operator=(typename Container::const_reference value) { if (p(value)) std::back_insert_iterator<Container>::operator=(value); @@ -40,12 +40,12 @@ public: conditional_back_insert_iterator& operator++(int) { return *this; } private: - Predicate& p; + Predicate p; }; template< class Container, class Predicate> -conditional_back_insert_iterator<Container, Predicate> conditional_back_inserter(Container& c, Predicate& p) { - return conditional_back_insert_iterator<Container, Predicate>(c, p); +conditional_back_insert_iterator<Container, Predicate> conditional_back_inserter(Container& c, Predicate&& p) { + return conditional_back_insert_iterator<Container, Predicate>(c, std::forward<Predicate>(p)); } } /* namespace datasketches */ --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
