leerho commented on a change in pull request #24:
URL:
https://github.com/apache/incubator-datasketches-postgresql/pull/24#discussion_r438944861
##########
File path: README.md
##########
@@ -16,9 +16,13 @@
specific language governing permissions and limitations
under the License.
-->
+# PostgreSQL Adaptor for C++ DataSketches
Review comment:
I was trying to make the terminology similar to the other adaptors, Hive
and Pig.
The term "adaptor" or "extension" is a matter of perspective. From the
perspective of PostgreSQL, the datasketches-postgresql repo provides an
_extension_ to PostgreSQL. From the perspective of the core DataSketches
library, the datasketches-postgresql repo provides an _adaptor_ for PostgreSQL.
Both are correct. You also make this distinction clear in the section below
called "PGXN Extension".
Perhaps we should change the above header to "DataSketches C++ Adaptor for
PostgreSQL"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
