AlexanderSaydakov commented on a change in pull request #324:
URL:
https://github.com/apache/incubator-datasketches-java/pull/324#discussion_r455480747
##########
File path: src/main/java/org/apache/datasketches/theta/SetOperationBuilder.java
##########
@@ -207,11 +207,11 @@ public SetOperation build(final Family family, final
WritableMemory dstMem) {
}
case A_NOT_B: {
if (dstMem == null) {
- setOp = new HeapAnotB(bSeed);
+ setOp = new AnotBimpl(bSeed);
}
else {
- throw new SketchesArgumentException(
- "AnotB is a stateless operation and cannot be persisted.");
+ throw new SketchesArgumentException( //TODO we should be able to do
this now.
Review comment:
is this TODO comment still relevant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
