jmalkin commented on a change in pull request #183:
URL: https://github.com/apache/datasketches-cpp/pull/183#discussion_r563538631
##########
File path: cpc/include/cpc_sketch_impl.hpp
##########
@@ -401,7 +406,7 @@ string<A> cpc_sketch_alloc<A>::to_string() const {
template<typename A>
void cpc_sketch_alloc<A>::serialize(std::ostream& os) const {
- compressed_state<A> compressed;
+ compressed_state<A> compressed(A(sliding_window.get_allocator()));
Review comment:
Should serialize() have the option of using a different allocator? It's
not entirely obvious that, say, a limited-size allocator would want transient
things like serialization to complete for space with the main stored data?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
