jmalkin commented on a change in pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189#discussion_r569042554
##########
File path: theta/CMakeLists.txt
##########
@@ -33,9 +33,21 @@ target_link_libraries(theta INTERFACE common)
target_compile_features(theta INTERFACE cxx_std_11)
set(theta_HEADERS "")
-list(APPEND theta_HEADERS
"include/theta_sketch.hpp;include/theta_union.hpp;include/theta_intersection.hpp")
-list(APPEND theta_HEADERS
"include/theta_a_not_b.hpp;include/theta_sketch_impl.hpp")
-list(APPEND theta_HEADERS
"include/theta_union_impl.hpp;include/theta_intersection_impl.hpp;include/theta_a_not_b_impl.hpp")
+list(APPEND theta_HEADERS
"include/theta_sketch.hpp;include/theta_sketch_impl.hpp")
+list(APPEND theta_HEADERS
"include/theta_union.hpp;include/theta_union_impl.hpp")
+list(APPEND theta_HEADERS
"include/theta_intersection.hpp;include/theta_intersection_impl.hpp")
+list(APPEND theta_HEADERS
"include/theta_a_not_b.hpp;include/theta_a_not_b_impl.hpp")
+list(APPEND tuple_HEADERS "include/theta_jaccard_similarity.hpp")
+list(APPEND tuple_HEADERS "include/theta_comparators.hpp")
Review comment:
should the rest of these be theta_HEADERS rather than tuple?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
