AlexanderSaydakov commented on a change in pull request #186:
URL: https://github.com/apache/datasketches-cpp/pull/186#discussion_r574003409
##########
File path: hll/include/HllUnion-internal.hpp
##########
@@ -226,7 +201,7 @@ HllSketchImpl<A>*
hll_union_alloc<A>::copy_or_downsample(const HllSketchImpl<A>*
return src->copyAs(HLL_8);
}
typedef typename std::allocator_traits<A>::template
rebind_alloc<Hll8Array<A>> hll8Alloc;
Review comment:
Missed this one. Purely a matter of style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
