This is an automated email from the ASF dual-hosted git repository. alsay pushed a commit to branch cleanup_warnings in repository https://gitbox.apache.org/repos/asf/datasketches-cpp.git
commit de53340389e9649765df363889735d198ed94e0d Merge: efc96b3 46c5f79 Author: Alexander Saydakov <[email protected]> AuthorDate: Thu Apr 1 10:10:54 2021 -0700 Merge remote-tracking branch 'origin/master' into cleanup_warnings kll/include/kll_quantile_calculator_impl.hpp | 3 ++- kll/include/kll_sketch_impl.hpp | 6 ++---- kll/test/kll_sketch_test.cpp | 14 +++++++++++--- 3 files changed, 15 insertions(+), 8 deletions(-) diff --cc kll/test/kll_sketch_test.cpp index 891b83b,f0c813e..b51f98b --- a/kll/test/kll_sketch_test.cpp +++ b/kll/test/kll_sketch_test.cpp @@@ -71,11 -71,10 +71,10 @@@ TEST_CASE("kll sketch", "[kll_sketch]" REQUIRE(sketch.get_CDF(split_points, 1).size() == 0); int count = 0; - for (auto& it: sketch) { + for (auto it: sketch) { (void) it; // to suppress "unused" warning - ++count; + FAIL("should be no iterations over an empty sketch"); } - REQUIRE(count == 0); } SECTION("get bad quantile") { --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
