davecromberge commented on a change in pull request #129:
URL:
https://github.com/apache/datasketches-memory/pull/129#discussion_r637785280
##########
File path: src/main/java/org/apache/datasketches/memory/BaseBuffer.java
##########
@@ -143,11 +92,7 @@ public final BaseBuffer setPosition(final long position) {
* @param position the given current position.
* @return BaseBuffer
*/
- public final BaseBuffer setAndCheckPosition(final long position) {
- checkInvariants(start, position, end, capacity);
- pos = position;
- return this;
- }
+ BaseBuffer setAndCheckPosition(long position);
Review comment:
Thanks for the detailed answer - this makes more sense to me now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
