leerho commented on a change in pull request #369:
URL: https://github.com/apache/datasketches-java/pull/369#discussion_r733215808
##########
File path: src/main/java/org/apache/datasketches/tuple/AnotB.java
##########
@@ -116,14 +117,23 @@ public void setA(final Sketch<S> skA) {
return;
}
//skA is not empty
- empty_ = false;
- thetaLong_ = skA.getThetaLong();
//process A
+ empty_ = false;
+ thetaLong_ = skA.getThetaLong();
final DataArrays<S> da = getDataArraysA(skA);
+
hashArr_ = da.hashArr;
- summaryArr_ = da.summaryArr;
+ hashArr_ = (hashArr_ == null) ? new long[0] : hashArr_;
curCount_ = hashArr_.length;
+
+ summaryArr_ = da.summaryArr;
+ if (summaryArr_ == null) {
+ final SummaryFactory<S> sumFact =
((QuickSelectSketch<S>)skA).getSummaryFactory();
+ final S summary = sumFact.newSummary();
+ final Class<S> summaryType = (Class<S>)summary.getClass();
+ summaryArr_ = (S[]) Array.newInstance(summaryType, 0);
+ }
Review comment:
In the Tuple sketch, instantiating the hash Array and the Summary array
is lazy, thus the getDataArrays method can return null. These nulls caused NPE
for certain corner cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
