jmalkin commented on pull request #266: URL: https://github.com/apache/datasketches-cpp/pull/266#issuecomment-1065697392
I didn't get a chance to comment, but even before the example I was able to trace the code and confirmed that this is a fix for a valid issue. I was apparently thinking of the (unused) compact case? I really dunno. Definitely my bug. We should definitely add a formal unit test here at some point, but I'm ok with merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
