leerho commented on PR #411: URL: https://github.com/apache/datasketches-java/pull/411#issuecomment-1207108377
This, unfortunately, is a massive PR, and will be difficult to review. Nevertheless, the main goals of this PR: - Fix the getQuantile(), getRank(), getPMF(), getCDF() for the REQ and KLL sketches so that they properly handle both INCLUSIVE and NON_INCLUSIVE queries. ( I haven't done this for classic quantiles, but this is already so big I decided to get this PR done and do another PR for classic. - This also involved fixing some bugs in the InequalitySearch and GenericInequalitySearch classes. These bugs only involved sketches with only a single item. - This also involved streamlining the Sorted View classes. By leveraging the SV classes for getRank, getCDF, and getPMF, I was able to eliminate over 300 lines of code. I haven't done this for REQ, as the savings was not quite as large, but may still decide to do this in REQ before we finally push to master. - Change all references to "item" to "value" for numeric valued quantile sketches. We decided to use "item" only for the generic sketches. This was huge as there were hundreds of uses of "item" in almost every class. - i did extensive rewrite of javadocs and code comments where I found them confusing or incomplete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
