jmalkin commented on code in PR #322:
URL: https://github.com/apache/datasketches-cpp/pull/322#discussion_r1062762503
##########
python/tests/vo_test.py:
##########
@@ -45,6 +45,13 @@ def test_vo_example(self):
items = vo.get_samples()
self.assertEqual(len(items), k)
+ count = 0
+ for tuple in vo:
+ sample = tuple[0]
+ weight = tuple[1]
Review Comment:
Discussed offline. It's exact modulo machine precision with the arithmetic,
but that's a fair point. It is reasonable to test that part only in C++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@datasketches.apache.org
For additional commands, e-mail: commits-h...@datasketches.apache.org
