jmalkin commented on code in PR #324:
URL: https://github.com/apache/datasketches-cpp/pull/324#discussion_r1064379687
##########
sampling/include/var_opt_sketch_impl.hpp:
##########
@@ -752,18 +752,16 @@ string<A> var_opt_sketch<T, A>::items_to_string(bool
print_gap) const {
std::ostringstream os;
os << "### Sketch Items" << std::endl;
const uint32_t array_length = (n_ < k_ ? n_ : k_ + 1);
- for (uint32_t i = 0, display_idx = 0; i < array_length; ++i) {
Review Comment:
i think `os << i` should actually have been `os << display_idx` in the loop
body
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
