c-dickens opened a new pull request, #325: URL: https://github.com/apache/datasketches-cpp/pull/325
An initial attempt at cpp count min sketch. Specific feedback that might be helpful: - `get_sketch()` would this be better as an iterator over the sketch table, rather than returning the table explicitly? - There is a danger of the hash seed addition overflowing. See `count_min_impl.hpp` lines 24 & 115. Is this problematic as it is passed as input to murmurhash? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
