jbapple opened a new issue, #328: URL: https://github.com/apache/datasketches-cpp/issues/328
`std::iterator` is deprecated; see https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0174r2.html#2.1. It is used ten times in datasketches-cpp: ``` $ git grep -c std::iterator fi/include/reverse_purge_hash_map.hpp:1 hll/include/HllArray.hpp:1 hll/include/coupon_iterator.hpp:1 kll/include/kll_sketch.hpp:1 quantiles/include/quantiles_sketch.hpp:1 req/include/req_sketch.hpp:1 sampling/include/var_opt_sketch.hpp:2 theta/include/theta_update_sketch_base.hpp:2 ``` Replace these inheritances with explicit using/typedef declarations in each class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
