jbapple commented on PR #338: URL: https://github.com/apache/datasketches-cpp/pull/338#issuecomment-1407240405
> I feel like it might be worth doing this for the other macros, too? Done. > Alternatively, would it make more sense to make this a namedspaced c++ thing? `ROTL64` and `CSA` (new in this commit) could be replaced by inline functions, which could be namespaced. The others cannot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
