jmalkin commented on code in PR #340: URL: https://github.com/apache/datasketches-cpp/pull/340#discussion_r1091273122
########## sampling/include/var_opt_union_impl.hpp: ########## @@ -508,9 +514,8 @@ void var_opt_union<T, A>::mark_moving_gadget_coercer(var_opt_sketch<T, A>& sk) c uint32_t result_r = 0; size_t next_r_pos = result_k; // = (result_k+1)-1, to fill R region from back to front - typedef typename std::allocator_traits<A>::template rebind_alloc<double> AllocDouble; - double* wts = AllocDouble().allocate(result_k + 1); - T* data = A().allocate(result_k + 1); + double* wts = AllocDouble(allocator_).allocate(result_k + 1); + T* data = A(allocator_).allocate(result_k + 1); Review Comment: Sorry, read the whole error more carefully and it didn't match due to const issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
