jmalkin commented on PR #325: URL: https://github.com/apache/datasketches-cpp/pull/325#issuecomment-1450778069
I think the Windows mystery is solved: From [https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners), Windows and Linux runners have a 7GB memory limit and that test was trying to allocated 8GB. Not actually sure how it let Linux pass, but moving a check into the constructor initialization list will address this in a way that avoids issues for anyone using the code, too, which I think was just pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
