jmalkin commented on code in PR #350:
URL: https://github.com/apache/datasketches-cpp/pull/350#discussion_r1129931622
##########
hll/include/Hll4Array-internal.hpp:
##########
@@ -210,7 +210,7 @@ void Hll4Array<A>::internalHll4Update(uint32_t slotNo,
uint8_t newVal) {
// we just increased a pair value, so it might be time to change curMin
if (actualOldValue == this->curMin_) { // 908
- this->decNumAtCurMin();
+ --(this->numAtCurMin_);
Review Comment:
i'm fine with this. but having it declared as inline i'd hope the impact of
the change is nothing on any modern compiler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
