jmalkin commented on code in PR #353:
URL: https://github.com/apache/datasketches-cpp/pull/353#discussion_r1156267492
##########
hll/include/Hll4Array-internal.hpp:
##########
@@ -114,10 +114,9 @@ uint8_t Hll4Array<A>::getSlot(uint32_t slotNo) const {
}
template<typename A>
-uint8_t Hll4Array<A>::get_value(uint32_t index) const {
- const uint8_t value = getSlot(index);
+uint8_t Hll4Array<A>::adjustRawValue(uint32_t slot, uint8_t value) const {
Review Comment:
i thought we were slowly migrating things to snake_case :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
