c-dickens commented on PR #360: URL: https://github.com/apache/datasketches-cpp/pull/360#issuecomment-1511665388
Actually, I don't think this is correct. Changing the family id causes the header to change so the [acceptable parameters](https://github.com/apache/datasketches-cpp/blob/034749f10fdb16e94c634191b3d0757816a1df2b/count/include/count_min_impl.hpp#L487) in `check_header_validity` need to change accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
