jmalkin commented on PR #436: URL: https://github.com/apache/datasketches-java/pull/436#issuecomment-1526944669
I'm a little confused. This PR was approved weeks ago, but then new commits were added without merging. And then we had a request for a new review and in the time since then there were yet more updates. The last seems to have been a merge from master, which shouldn't even be part of a PR as that can pull in unrelated conflicts that increase the length of the code to review unnecessarily. Anyway, as this is still changing the review request seems premature. Please let us know when the branch is done and ready for review. And once approved, please merge and use a new branch for subsequent fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
