jmalkin commented on issue #361: URL: https://github.com/apache/datasketches-cpp/issues/361#issuecomment-1528245172
Just an update on where we are. While still skeptical of whether we really want to add a "shoot yourself in the foot" button in general, it's not an unreasonable request in a limited set of circumstances. The next question is how to do this sanely. We recently made a change to provide thread local randomness as the previous implementation wasn't thread-safe. That's good in general but problematic when setting the seed. Thread id isn't a stable thing, at least not on across OSes. We also want to make sure that trying enable making the sketch deterministic doesn't kill performance or lead to a substantial increase in memory use. Any such state also wouldn't be persisted during serialization. One possibility is that setting the seed would preclude proper multithreaded behavior. That seems...not ideal, but perhaps a necessary trade-off given other considerations. But that opens up the problem of determining when we're trying to use the sketch in a multithreaded context. At least in C++ (as opposed to our Java library) we do have the option to use `#ifdef`s, although we don't want to be too aggressive with them. Any suggestions here are welcome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
