jmalkin commented on code in PR #393:
URL: https://github.com/apache/datasketches-cpp/pull/393#discussion_r1318849894
##########
README.md:
##########
@@ -92,13 +90,6 @@ from GitHub using CMake's `ExternalProject` module. The code
would look somethin
GIT_SUBMODULES ""
INSTALL_DIR /tmp/datasketches-prefix
CMAKE_ARGS -DBUILD_TESTS=OFF -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
-DCMAKE_INSTALL_PREFIX=/tmp/datasketches-prefix
-
- # Override the install command to add DESTDIR
Review Comment:
Let's reword this a bit but restore it. Something like:
"If building an RPM of the library, you may need...."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
