This is an automated email from the ASF dual-hosted git repository.

leerho pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datasketches-memory17.git

commit 895f2d557d16ceab7f0846af910c979dce9bf778
Author: Lee Rhodes <[email protected]>
AuthorDate: Mon Oct 2 10:42:49 2023 -0700

    Compile & test works from both Eclipse and Maven now, but not from the
    command line trying to run testNG directly from the CL.
---
 compile.sh                                            |  2 +-
 pom.xml                                               |  5 -----
 .../memory/internal/NativeWritableMemoryImplTest.java |  3 ++-
 testng.xml                                            | 19 +++++++++++++++++++
 4 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/compile.sh b/compile.sh
index 8b62bfd..adfb25d 100755
--- a/compile.sh
+++ b/compile.sh
@@ -42,7 +42,7 @@ $JAVAC \
 
 echo " # create jar datasketches-memory-3.0.0.jar from src/main/java"
 $JAR --create \
-  --file mods/datasketches-memory-3.0.0.jar \
+  --file libs/datasketches-memory-3.0.0.jar \
   -C target/classes .
 
 echo " # compile tests from src/test/java"
diff --git a/pom.xml b/pom.xml
index b297e2b..da614c2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -394,11 +394,6 @@ under the License.
             <jdkToolchain>
               <version>${jdk-toolchain.version}</version>
             </jdkToolchain>
-            <!--
-            <configuration>
-              <argLine>${argline} --add-module --patch-module ... </argline>
-            </configuration>
-            -->
             
<reportsDirectory>${project.build.directory}/test-output/${maven.build.timestamp}</reportsDirectory>
           </configuration>
         </plugin>
diff --git 
a/src/test/java/org/apache/datasketches/memory/internal/NativeWritableMemoryImplTest.java
 
b/src/test/java/org/apache/datasketches/memory/internal/NativeWritableMemoryImplTest.java
index 653f5a2..76b739e 100644
--- 
a/src/test/java/org/apache/datasketches/memory/internal/NativeWritableMemoryImplTest.java
+++ 
b/src/test/java/org/apache/datasketches/memory/internal/NativeWritableMemoryImplTest.java
@@ -657,7 +657,8 @@ public class NativeWritableMemoryImplTest {
     wmem.asWritableBuffer();
   }
 
-  @Test void checkZeroMemory() {
+  @Test
+  public void checkZeroMemory() {
     WritableMemory wmem = WritableMemory.allocate(8);
     WritableMemory reg = wmem.writableRegion(0, 0);
     assertEquals(reg.getCapacity(), 0);
diff --git a/testng.xml b/testng.xml
index 7e483b2..81529bf 100644
--- a/testng.xml
+++ b/testng.xml
@@ -1,6 +1,25 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd";>
 
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
 <suite name="Testing Memory17">
   <test name="Test ALL">
     <classes>


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to