This is an automated email from the ASF dual-hosted git repository.
jmalkin pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/datasketches-cpp.git
from 253eacf Merge pull request #397 from apache/intesection_speed_fix
new 3da32a4 initial draft of EB-PPS sampling sketch
new 205212f add missing cassert include for now (to remove when finishing
testing)
new 437a3ca broken attempt at iterator
new 47e3935 finish fixing iterator
new cd6a661 add merge
new 4f8e7b1 Add serialization draft -- untested so assume it has bugs
new c24f2bc remove depdence on c++20 numbers header
new 79c81b8 remove some validation code, tests still very much WIP
new 1269d30 Remove validation code, change tests but still WIP as
characterization rather than proper unit tests
new cd81179 WIP - debugging new merge, placeholder before memory testing
new d0c3e17 fix rvalue vs lvalue merge
new 87919de Clean up unused code (naive merge) and improve merge comment
description
new 47d2843 Have cmake (via ctest) print output on failed tests to better
enable debugging
new c95d264 improve bounds check on k to avoid attempt at large
allocation that fails
new c04ef08 add missing comma, remove extra paren
new 034d15e simplify API, move characterization tests elsewhere for now
new 1183e17 tests for ebpps sample
new 6a8b243 check invalid input weights
new 3310f64 add tests, but also trigger a memory bug. checking in to
test on an OS that supports valgrind
new 53a81af refactor serialization so sample handles itself, fix problem
with not using deleter to recover from errors in serialization
new 9972efd add stream serialization tests
new bef2049 check k range during deserialization
new eab3328 don't release() unique_ptr memory we need to free
new 1a376fb create vector directly in deserialize rather than passing
memory around
new 412d4c2 add merge unit tests
new 1370154 cleanup and restore missing close brace
new 6d5b1a4 fix typing for custom allocator, split varopt vs ebpps
testing binary -- but some segfault with custom allocator
new 3b7f413 add ebpps custom allocator test
new 72b5c21 properly clear partial item whenever the value is moved out
new c70450f add proper citation of source paper, improve to_string()
new 54db08f make sampling test cmake current with compatibility changes
since forking the branch
new 91a0943 remove unnecessary extra addition of path in cmake
new 89ea881 Merge branch 'master' into ebpps
new e452937 address review comments, including a clarification in
var_opt, and fix a stream serialization bug
new 0328686 remove characterization from testing code
new 90176b6 Merge pull request #396 from jmalkin/ebpps
The 1694 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CMakeLists.txt | 1 +
common/include/common_defs.hpp | 5 +-
sampling/CMakeLists.txt | 4 +
sampling/include/ebpps_sample.hpp | 210 ++++++++
sampling/include/ebpps_sample_impl.hpp | 535 +++++++++++++++++++++
sampling/include/ebpps_sketch.hpp | 282 +++++++++++
sampling/include/ebpps_sketch_impl.hpp | 531 ++++++++++++++++++++
sampling/include/var_opt_sketch.hpp | 3 +-
sampling/test/CMakeLists.txt | 46 +-
...location_test.cpp => ebpps_allocation_test.cpp} | 58 +--
sampling/test/ebpps_sample_test.cpp | 137 ++++++
sampling/test/ebpps_sketch_test.cpp | 266 ++++++++++
12 files changed, 2040 insertions(+), 38 deletions(-)
create mode 100644 sampling/include/ebpps_sample.hpp
create mode 100644 sampling/include/ebpps_sample_impl.hpp
create mode 100644 sampling/include/ebpps_sketch.hpp
create mode 100644 sampling/include/ebpps_sketch_impl.hpp
copy sampling/test/{var_opt_allocation_test.cpp => ebpps_allocation_test.cpp}
(55%)
create mode 100644 sampling/test/ebpps_sample_test.cpp
create mode 100644 sampling/test/ebpps_sketch_test.cpp
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
