jmalkin commented on code in PR #399: URL: https://github.com/apache/datasketches-cpp/pull/399#discussion_r1373872360
########## tuple/include/array_tuple_union_impl.hpp: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +namespace datasketches { + +template<typename Array, typename Policy, typename Allocator> +array_tuple_union<Array, Policy, Allocator>::array_tuple_union(uint8_t lg_cur_size, uint8_t lg_nom_size, resize_factor rf, float p, uint64_t theta, uint64_t seed, const Policy& policy, const Allocator& allocator): +Base(lg_cur_size, lg_nom_size, rf, p, theta, seed, policy, allocator) +{} + +template<typename Array, typename Policy, typename Allocator> +auto array_tuple_union<Array, Policy, Allocator>::get_result(bool ordered) const -> CompactSketch { + return CompactSketch(this->state_.get_policy().get_policy().get_num_values(), Base::get_result(ordered)); Review Comment: do we need to change this, too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
