AlexanderSaydakov commented on code in PR #404:
URL: https://github.com/apache/datasketches-cpp/pull/404#discussion_r1383934189
##########
kll/include/kll_sketch.hpp:
##########
@@ -162,6 +167,7 @@ class kll_sketch {
public:
using value_type = T;
using comparator = C;
Review Comment:
We are not very consistent with this. Perhaps, we should adopt some
consistent rules. In this case value_type alias is to follow convention in STL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
