adarshsanjeev commented on issue #478: URL: https://github.com/apache/datasketches-java/issues/478#issuecomment-1837869664
@leerho Thanks for the comments! For the first approach, going through the code, `HllSketch.wrap(mem)` has a lot of further checks, but I don't see anything very expensive getting called. I can confirm that and see if the performance is similar with that check. For the binary checking approach, I believe `isSaveToConvertToNullSketch` implements something similar (checking the implemntation and then checking the bytes that specify the size for each of them separately). I was not sure if the implementation would always be a list implementation, hence the extra checks for set and sketch implementations as well. I can remove this part of the code if it is guaranteed that it would be a list implementation internally for all empty sketches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
