leerho commented on issue #481: URL: https://github.com/apache/datasketches-java/issues/481#issuecomment-1843956763
@edmondliuTTD Again, thank you for your interest in our library. First, to answer your question above: > Is it feasible to update quantile sketches (with a focus on KLL) with multiple values at once rather than one at a time, especially if those values are identical? Yes, it is feasible and it is called a "weighted quantiles sketch". And if based on the KLL algorithm it would be called a "KllWeightedSketch". But implementing it correctly does require a deeper understanding of how the KLL (or classic Quantiles) sketches work. Specifically, it needs to be implemented so that the update cost is _**O(log(m)),**_ and not _**O(m)**_, where _m_ is the number of duplicates to be entered. You are not the first person to request such a sketch, so we just might be able to get around to it in the near future. Unfortunately, the PR you submitted does not qualify because your cost of updating _m_ items is _**O(m)**_. So I will be closing your PR. Nonetheless, please stay in touch, because when we do implement a weighted quantiles sketch, you could help out in validating that it would work for you. We would be interested to find out if you (or TTD) are using any of our other sketches and we would be grateful for any feedback. Cheers, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
