AlexanderSaydakov commented on issue #409: URL: https://github.com/apache/datasketches-cpp/issues/409#issuecomment-1868105273
I am looking at the code to merge t-digests. I don't like that a modifying operation compress() is called on the input t-digests. I wonder whether this is avoidable. I would think this is done for simplicity to avoid dealing with unmerged buffer in the incoming t-digests, however the compress() method forces compression even if the buffer is empty. There is a practice in C++ to pass const reference to the input object. Having a requirement of a mutable input is quite ugly. And forcing compression unnecessarily is even worse. I am not sure how to deal with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
