leerho commented on issue #510: URL: https://github.com/apache/datasketches-java/issues/510#issuecomment-1955176054
This is a valuable suggestion. But it begs the question of whether we need to add this capability to all the other array update methods ... String, char[], int[], long[] ... which kinda bloats the API. Or, instead, add an update(ByteBuffer). And/Or, add an update(Memory). The last two methods allow wrapping of any primitive array and creating a view of it to pass to the sketch, all without any copies. (with ByteBuffer and the multibyte primitives, one has to be very careful to be explicit about endianness.) This suggestion also begs the question of whether we need to do this with our other unique counting sketches: CPC and Tuple. HLL already has an update(ByteBuffer). Thoughts? Would you also be willing to help with PRs for the other unique counting sketches? Cheers, and thanks for the suggestion!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
