This is an automated email from the ASF dual-hosted git repository. jmalkin pushed a commit to branch 5.0.X-backport in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit 765fdf22fb0685b5e73aeb0ee08c4b1c6d0a4538 Author: Lee Rhodes <[email protected]> AuthorDate: Fri Feb 16 12:20:33 2024 -0800 Just want to see if this fixes the CodeQL issue with /tuple/QuickSelectSketch --- .github/workflows/codeql-analysis.yml | 6 +++--- src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 9faa687e..7cb4c897 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -32,7 +32,7 @@ jobs: # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL - uses: github/codeql-action/init@v2 + uses: github/codeql-action/init@v3 with: languages: ${{ matrix.language }} # If you wish to specify custom queries, you can do so here or in a config file. @@ -46,7 +46,7 @@ jobs: # Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java). # If this step fails, then you should remove it and run the build manually (see below) - name: Autobuild - uses: github/codeql-action/autobuild@v2 + uses: github/codeql-action/autobuild@v3 # âšī¸ Command-line programs to run using the OS shell. # đ See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun @@ -59,6 +59,6 @@ jobs: # ./location_of_script_within_repo/buildscript.sh - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@v2 + uses: github/codeql-action/analyze@v3 with: category: "/language:${{matrix.language}}" diff --git a/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java b/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java index 68d2c44b..2cc0d989 100644 --- a/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java +++ b/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java @@ -58,7 +58,8 @@ class QuickSelectSketch<S extends Summary> extends Sketch<S> { S[] summaryTable_; @Override - protected final void finalize() { + protected final void finalize() throws Throwable { + super.finalize(); // SpotBugs CT_CONSTUCTOR_THROW, OBJ11-J } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
