AlexanderSaydakov commented on code in PR #558: URL: https://github.com/apache/datasketches-java/pull/558#discussion_r1605592000
########## src/main/java/org/apache/datasketches/filters/quotientfilter/QuickBitVector.java: ########## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.datasketches.filters.quotientfilter; + +/* +Copyright � 1999 CERN - European Organization for Nuclear Research. +Permission to use, copy, modify, distribute and sell this software and its documentation for any purpose +is hereby granted without fee, provided that the above copyright notice appear in all copies and +that both that copyright notice and this permission notice appear in supporting documentation. +CERN makes no representations about the suitability of this software for any purpose. +It is provided "as is" without expressed or implied warranty. +*/ + +/** + * Implements quick non polymorphic non bounds checking low level bitvector operations. + * Includes some operations that interpret sub-bitstrings as long integers. + * <p> + * <b>WARNING: Methods of this class do not check preconditions.</b> + * Provided with invalid parameters these method may return (or set) invalid values without throwing any exception. + * <b>You should only use this class when performance is critical and you are absolutely sure that indexes are within bounds.</b> + * <p> + * A bitvector is modelled as a long array, i.e. long[] bits holds bits of a bitvector. + * Each long value holds 64 bits. + * The i-th bit is stored in bits[i/64] at + * bit position i % 64 (where bit position 0 refers to the least + * significant bit and 63 refers to the most significant bit). + * + * @author [email protected] + * @version 1.0, 09/24/99 + * @see java.util.BitSet + */ +//package bitmap_implementations; + +public class QuickBitVector extends Object { Review Comment: "extends Object" is implied (not a big deal) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
