This is an automated email from the ASF dual-hosted git repository.
leerho pushed a commit to branch integrateJava17_v3
in repository https://gitbox.apache.org/repos/asf/datasketches-memory.git
The following commit(s) were added to refs/heads/integrateJava17_v3 by this
push:
new 50d4f9b Add getArray(), comment out a bunch of SuppressWarnings:
resource & javadoc.
50d4f9b is described below
commit 50d4f9b8441faf51c146149821ade91d2307004e
Author: Lee Rhodes <[email protected]>
AuthorDate: Wed May 29 13:51:05 2024 -0700
Add getArray(), comment out a bunch of SuppressWarnings: resource &
javadoc.
---
src/main/java/org/apache/datasketches/memory/WritableMemory.java | 6 ++++++
.../org/apache/datasketches/memory/internal/BaseStateImpl.java | 4 ++--
.../datasketches/memory/internal/BaseWritableMemoryImpl.java | 9 +++++++--
src/main/java/org/apache/datasketches/memory/internal/Util.java | 2 +-
4 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/src/main/java/org/apache/datasketches/memory/WritableMemory.java
b/src/main/java/org/apache/datasketches/memory/WritableMemory.java
index 4eaedf1..321090f 100644
--- a/src/main/java/org/apache/datasketches/memory/WritableMemory.java
+++ b/src/main/java/org/apache/datasketches/memory/WritableMemory.java
@@ -542,6 +542,12 @@ public interface WritableMemory extends Memory {
//OTHER WRITABLE API METHODS
+ /**
+ * Returns a copy of the primitive backing byte array.
+ * @return a copy of the primitive backing byte array.
+ */
+ byte[] getArray();
+
/**
* WritableMemory enables the MemoryRequestServer Direct (Native) Memory
backed resources.
* Other backed resources will always return null.
diff --git
a/src/main/java/org/apache/datasketches/memory/internal/BaseStateImpl.java
b/src/main/java/org/apache/datasketches/memory/internal/BaseStateImpl.java
index 891f283..575f3c7 100644
--- a/src/main/java/org/apache/datasketches/memory/internal/BaseStateImpl.java
+++ b/src/main/java/org/apache/datasketches/memory/internal/BaseStateImpl.java
@@ -271,7 +271,7 @@ abstract class BaseStateImpl implements BaseState {
return byteBuf;
}
- @SuppressWarnings("resource")
+ //@SuppressWarnings("resource")
@Override
public void close() {
if (seg != null && seg.scope().isAlive() && !seg.scope().isImplicit()) {
@@ -322,7 +322,7 @@ abstract class BaseStateImpl implements BaseState {
return memReqSvr != null;
}
- @SuppressWarnings("resource")
+ //@SuppressWarnings("resource")
@Override
public boolean isAlive() { return seg.scope().isAlive(); }
diff --git
a/src/main/java/org/apache/datasketches/memory/internal/BaseWritableMemoryImpl.java
b/src/main/java/org/apache/datasketches/memory/internal/BaseWritableMemoryImpl.java
index c458d80..9aaa27f 100644
---
a/src/main/java/org/apache/datasketches/memory/internal/BaseWritableMemoryImpl.java
+++
b/src/main/java/org/apache/datasketches/memory/internal/BaseWritableMemoryImpl.java
@@ -122,7 +122,7 @@ public abstract class BaseWritableMemoryImpl extends
BaseStateImpl implements Wr
//MAP FILE RESOURCE
- @SuppressWarnings("resource")
+ //@SuppressWarnings("resource")
public static WritableMemory wrapMap(
final File file,
final long fileOffsetBytes,
@@ -161,7 +161,7 @@ public abstract class BaseWritableMemoryImpl extends
BaseStateImpl implements Wr
* This is a callback mechanism for a user client of direct memory to
request more memory.
* @return WritableMemory
*/
- @SuppressWarnings("resource")
+ //@SuppressWarnings("resource")
public static WritableMemory wrapDirect(
final long capacityBytes,
final long alignmentBytes,
@@ -363,6 +363,11 @@ public abstract class BaseWritableMemoryImpl extends
BaseStateImpl implements Wr
slice.fill(value);
}
+ @Override
+ public final byte[] getArray() {
+ return seg.toByteArray();
+ }
+
@Override
public final void setBits(final long offsetBytes, final byte bitMask) {
final byte b = MemoryAccess.getByteAtOffset(seg, offsetBytes);
diff --git a/src/main/java/org/apache/datasketches/memory/internal/Util.java
b/src/main/java/org/apache/datasketches/memory/internal/Util.java
index 07c0a7a..c371d5a 100644
--- a/src/main/java/org/apache/datasketches/memory/internal/Util.java
+++ b/src/main/java/org/apache/datasketches/memory/internal/Util.java
@@ -31,7 +31,7 @@ import java.util.Objects;
/**
* @author Lee Rhodes
*/
-@SuppressWarnings("javadoc")
+//@SuppressWarnings("javadoc")
final class Util {
static final String LS = System.getProperty("line.separator");
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
