jmalkin opened a new pull request, #567: URL: https://github.com/apache/datasketches-java/pull/567
Refactored BloomFilter's `BitArray` class to make it common across filters. That involved making it public, so all the methods in the abstract base class now have a javadoc. BitArray now has `getBits(index, numBits)` and `setBits(index, numBits, value)` (where the max size is 64 bits) as well as `assignBit(index, value)`. The QuotientFilter has been updated to use this class, and the old Bitmap wrapping some legacy CERN code has been removed. Opening this against the reviewed branch, but we probably then want to merge back into quotient-filter after that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
