jmalkin opened a new pull request, #438: URL: https://github.com/apache/datasketches-cpp/pull/438
I think this is a complete filter, including compatibility tests iwht java (that are not yet implemented in java!). I'm look for feedback on how I handled wrapping. It feels a little too parallel to java in some ways, with `wrap()` vs `writable_wrap()`, which I'm not sure is a good idea. The other issue is taht the former returns a const sketch, but counting the number of bits set may require modifying the filter. It should compute the number if it's in read-only mode so I could potentially add a const version of that method -- or just make it not update the internal state. Anyway, I'm fairly sure there are missed const values and other changes needed. But feel free to start with big picture design first and then move to details once we're happy with the overall structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
