leerho commented on PR #241:
URL:
https://github.com/apache/datasketches-memory/pull/241#issuecomment-2484062564
Thank you for your work on this. A couple of things:
- The GitHub/Actions/Workflows will need to be updated to Java 21.
Otherwise, guaranteed to fail.
- I am not familiar with NetBeans IDE, but the comments in the
nb-configurations.xml file are concerning:
- "The configuration is intended to be shared among all the users of
project and
therefore it is assumed to be part of version control checkout." -- I
presume this only applies to all NetBeans users only??
- "Without this configuration present, some functionality in the IDE may
be limited or fail altogether."
- We don't allow IDE specific configuration files to be part of the
version control or part of the released project. Our developers use a number of
different IDEs, and they keep their own IDE configuration files as part of
their own development environment. So we need to figure out how we can do this
without this config file.
- The warning seems severe to me, since all of the changes you have
made are nothing but pure java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
