frankgrimes97 opened a new pull request, #77:
URL: https://github.com/apache/datasketches-characterization/pull/77
A toolchain entry for each of Java 8, 11, 17, 21 is now required.
The parent `pom.xml` build can be run with any of JDK 8, 11, 17, 21 and each
submodule correctly compiles and runs with the selected Java version and
corresponding `datasketches-java`/`dataskeches-memory` (DS) library versions.
Each of the Java 11, 17, 21 characterization (`c14n`) submodules bootstrap
their JobProfile sources and configs from the Java 8 base module. The sources
and configs are copied from the `../java-base/src/(java|resources)` to
`./generated-(sources|resources)/java-base`.
This helps avoid code duplication and drift while still allowing for
selectively overriding the subset of characterization tests which need to
account for API incompatibilities introduced in the newer DS library versions.
Those overridden JobProfiles can be explicitly excluded from being copied from
`java-base` using `<exclude>` entries in the given submodule's build file and
instead alternative implementations can be provided in the given submodule's
own `src/main/java/` directory.
Examples of this exclusion can be seen in the `java-seventeen` and
`java-twenty-one` submodules' `pom.xml` files.
This use of `src/main/generated-(sources|resources)` in conjunction with the
org.codehaus.mojo.build-helper-maven-plugin's `add-source` Maven goal allows
IDE integration to continue to work seamlessly.
Building/testing/running was verified to work correct in the following IDEs:
- IntelliJ IDEA 2024.3.3 (Community Edition)
- Eclipse IDE 2024-12 (4.34.0)
- Apache NetBeans IDE 25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@datasketches.apache.org
For additional commands, e-mail: commits-h...@datasketches.apache.org
