AlexanderSaydakov commented on code in PR #458:
URL: https://github.com/apache/datasketches-cpp/pull/458#discussion_r2141157119
##########
tdigest/include/tdigest_impl.hpp:
##########
@@ -638,11 +656,11 @@ template <typename T, typename A>
}
template<typename T, typename A>
-tdigest<T, A>::const_iterator::const_iterator(const tdigest& tdigest_, const
bool is_end):
- centroids_()
+tdigest<T, A>::const_iterator::const_iterator(const tdigest<T, A>& tdigest_,
const bool is_end):
+ centroids_(tdigest_.get_allocator())
{
// Create a copy of the tdigest to generate the centroids after processing
the buffered values
- tdigest tmp(tdigest_);
+ tdigest<T, A> tmp(tdigest_);
Review Comment:
Could you also remove the unnecessary parameters <T, A> in two places above?
This is nit picking, but let's be consistent while we still remember.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@datasketches.apache.org
For additional commands, e-mail: commits-h...@datasketches.apache.org
