proost opened a new issue, #485: URL: https://github.com/apache/datasketches-cpp/issues/485
1. [`MIN_LG_ARR_ITEMS` is 3 in C++](https://github.com/apache/datasketches-cpp/blob/4f069a3056672d45694ac12505a5a14d7fce1a02/sampling/include/var_opt_sketch.hpp#L266), but [`MIN_LG_ARR_ITEMS` is 4 in Java](https://github.com/apache/datasketches-java/blob/53b312ec2d32f32261fbaf803a8287f5ebb4ff45/src/main/java/org/apache/datasketches/sampling/VarOptItemsSketch.java#L77). which one is correct? Or it depends on language? 2. [C++ skips if item's weight is zero](https://github.com/apache/datasketches-cpp/blob/4f069a3056672d45694ac12505a5a14d7fce1a02/sampling/include/var_opt_sketch_impl.hpp#L778). But [Java throws exception ](https://github.com/apache/datasketches-java/blob/53b312ec2d32f32261fbaf803a8287f5ebb4ff45/src/main/java/org/apache/datasketches/sampling/VarOptItemsSketch.java#L830). [original paper](https://arxiv.org/pdf/0803.0473) said, ``` we are dealing with a stream of items where item i has a positive weight wi ``` So throwing exception when weight is zero, more correct to me. But are there reason to skip in C++? cc. @jmalkin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
