jihuayu commented on code in PR #503:
URL: https://github.com/apache/datasketches-cpp/pull/503#discussion_r3362913550
##########
hll/include/CouponList-internal.hpp:
##########
@@ -99,6 +99,13 @@ CouponList<A>* CouponList<A>::newList(const void* bytes,
size_t len, const A& al
const bool emptyFlag = ((data[hll_constants::FLAGS_BYTE] &
hll_constants::EMPTY_FLAG_MASK) ? true : false);
const uint32_t couponCount = data[hll_constants::LIST_COUNT_BYTE];
+ // Reject LIST counts at or above the fixed LIST capacity.
+ const uint32_t listCapacity = 1u << hll_constants::LG_INIT_LIST_SIZE;
+ if (couponCount >= listCapacity) {
+ throw std::invalid_argument("Attempt to deserialize invalid CouponList
with couponCount >= capacity. Found couponCount: "
+ + std::to_string(couponCount)
+ + ", capacity: " +
std::to_string(listCapacity));
+ }
Review Comment:
I think this repetition makes the code easier to read, and extracting it
into a function is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
