freakyzoidberg opened a new pull request, #283:
URL: https://github.com/apache/datasketches-memory/pull/283

   ## Summary
   
   - Adds `*.txt text eol=lf` to `.gitattributes` to ensure `.txt` test 
resources are always checked out with LF endings regardless of the build 
platform.
   - Fixes 2 test failures introduced in 7.0.0-RC1 when the 
`stageReleaseSources` workflow was switched from Ubuntu to Windows (`runs-on: 
windows-latest`), causing `GettysburgAddress.txt` to be packaged with CRLF 
endings (1548 bytes) instead of LF (1541 bytes).
   
   ## Failing tests in RC1 (now fixed)
   
   - `AllocateDirectMapMemoryTest.printGettysburgAddress` — byte offset 
mismatch due to CRLF shifting positions
   - `UtilTest.resourceBytesCorrect` — file size assertion failed (expected 
1541, got 1548)
   
   ## Test plan
   
   - [ ] Build from source zip created on Windows and verify both tests pass
   - [ ] Verify `GettysburgAddress.txt` in the zip has LF endings after this 
change
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to