Copilot commented on code in PR #504: URL: https://github.com/apache/datasketches-cpp/pull/504#discussion_r3438047227
########## .gitattributes: ########## @@ -0,0 +1,42 @@ +# The default behavior, which overrides 'core.autocrlf', is to use Git's +# built-in heuristics to determine whether a particular file is text or binary. +# Text files are automatically normalized to the user's platforms. +# 15 years ago this was probably OK, but today it is a bad idea. +* text=auto eol=lf + +# Explicitly declare text files that should always be LF +.asf.yaml text eol=lf +.gitattributes text eol=lf +.gitignore text eol=lf +git.properties text eol=lf +LICENSE text eol=lf +NOTICE text eol=lf +*.html text eol=lf +*.hpp text eol=lf +*.cpp text eol=lf +*.sk text eol=lf +*.md text eol=lf +*.properties text eol=lf +*.sh text eol=lf +*.xml text eol=lf +*.yml text eol=lf +*.yaml text eol=lf +*.txt text eol=lf +GettysburgAddress.txt text eol=lf Review Comment: `GettysburgAddress.txt` doesn't exist in this repository, so this entry is currently unused and could be removed to keep the attributes file focused on actual project files. ########## .gitattributes: ########## @@ -0,0 +1,42 @@ +# The default behavior, which overrides 'core.autocrlf', is to use Git's +# built-in heuristics to determine whether a particular file is text or binary. +# Text files are automatically normalized to the user's platforms. +# 15 years ago this was probably OK, but today it is a bad idea. +* text=auto eol=lf + +# Explicitly declare text files that should always be LF +.asf.yaml text eol=lf +.gitattributes text eol=lf +.gitignore text eol=lf +git.properties text eol=lf Review Comment: `git.properties` doesn't exist in this repository, so this pattern is currently a no-op and may be confusing to future maintainers. Consider removing it unless it's intentionally reserved for a planned file. ########## .gitattributes: ########## @@ -0,0 +1,42 @@ +# The default behavior, which overrides 'core.autocrlf', is to use Git's +# built-in heuristics to determine whether a particular file is text or binary. +# Text files are automatically normalized to the user's platforms. +# 15 years ago this was probably OK, but today it is a bad idea. +* text=auto eol=lf Review Comment: The header comment says text files are normalized to the user's platform, but this file explicitly forces `eol=lf` for all auto-detected text. Updating the comment to match the enforced LF checkout behavior will reduce confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
