tisonkun commented on PR #505:
URL: https://github.com/apache/datasketches-cpp/pull/505#issuecomment-4795607713

   > Thank you! I agree with changing file extension to ".sk".
   
   I agree with this. I can update it in this PR or do it in a follow-up.
   
   One possible impact is that datasketches-java and datasketches-go, IIRC, 
test against these snapshot files. So they may be affected by the name changes 
as well. But for sure we can update there cascadingly, just need to inform all 
the related devs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to