leerho commented on PR #517: URL: https://github.com/apache/datasketches-cpp/pull/517#issuecomment-5472696519
C++ should follow the example of Java, which preceded C++ by quite a while. You are correct that the Empty Compact Sketch layout should set the seed hash to all zeros, to be ignored. Look carefully at the Java EmptyCompactSketch as it was designed for backward compatibility as well. If you vouch for that here, then I will approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
