proost commented on PR #519: URL: https://github.com/apache/datasketches-cpp/pull/519#issuecomment-5526923542
@SavicStefan Now I understand your intention. you're right that the mismatch is undetectable from the format alone. But that's structural, not a gap to patch. See [this](https://github.com/apache/datasketches-java/blob/3a1bf7f2f22e78c0c227bbe409ce4b4f386f630c/src/main/java/org/apache/datasketches/tuple/SummaryDeserializer.java#L30-L39). It can't distinguish a wrong summary type from a larger buffer or a SerDe that over-report. And also some users will be relying on it, This change would break them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
