leerho commented on issue #533: URL: https://github.com/apache/datasketches-cpp/issues/533#issuecomment-5960304783
Your proposal makes sense. We should revert C++ AoS for 5.3.0. It removes the release blocker today, and the C++ AoS sketch never ships with incompatible hashing. I will open a disscussion on dev@ WRT the earlier UTF-8 validation discussion[1]. what we missed before was the already released Java AoS that used UTF-16, no BOM, which has been out for years. This discussion should not be rushed. Claude helped me determine that the revert can be done cleanly: no later commits touch the 8 affected files, five can be deleted outright, and only two CMakeLists.txt files plus 39 lines in array_tuple_sketch.hpp need edits, with no downstream Python bindings at risk. Claude can test the revert locally without pushing to check if anything later depends on those 39 lines. If you are short on time I can have Claude do the revert for you. **With your permission** I can push the revert and open the PR for you to approve quickly, which will allow us to move forward on 5.3.0. There are some ripple effects for the revert: - Release notes: remove the "AoS tuple sketch (#476)" line from New Features. - The TCK: the next C++ snapshot update will drop the aos_*_cpp.sk files. Java's cross-language test already skips missing files, so nothing breaks. - Go #191 stays open. Go has already released AoS, so it still needs fixing there, and the outcome of the dev@ discussion will decide how. As for the rewrite, we don't need a 3rd party library to do a conversion from UTF-8 to UTF-16E: it is about 30 lines of code with no dependencies and reproduces Java's encoding exactly (what you also suggested in February). I could have Claude help with the rewrite also, but we need the result of the discussion for that and your go-ahead. [1]: [DISCUSS] UTF-8 validation for string SerDe across sketches", 14 messages from Feb 14 to Mar 12, 2026. [https://lists.apache.org/thread/8p36zbmjp57fcjq7tlss69zy67459jv1](https://lists.apache.org/thread/8p36zbmjp57fcjq7tlss69zy67459jv1) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
